Re: [PATCH/RFC 2/5] [PATCH] sched: pass sched_domain_level tosched_power_savings_store

From: Andreas Herrmann
Date: Thu Aug 19 2010 - 08:26:43 EST


On Mon, Aug 16, 2010 at 04:29:57AM -0400, Peter Zijlstra wrote:
> On Thu, 2010-08-12 at 19:25 +0200, Heiko Carstens wrote:
> > Pass the corresponding sched domain level to sched_power_savings_store instead
> > of a yes/no flag which indicates if the level is SMT or MC.
> > This is needed to easily extend the function so it can be used for a third
> > level.
>
> Ah, so the plan is to reduce the number of knobs, not create more.

Don't think so.

> Sysadmins really aren't interested in having a powersavings knob per
> topology level.

It just allows to use the same store functions for three instead of
two different knobs.


Andreas



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/