Re: [PATCH] ecryptfs: properly mark init functions

[Jerome Marchand]

On 08/19/2010 02:28 AM, Tyler Hicks wrote:
> On Tue Aug 17, 2010 at 05:24:05PM +0200, Jerome Marchand <jmarchan@xxxxxxxxxx> wrote:
>>
>> Some ecryptfs init functions are not prefixed by __init and thus not
>> freed after initialization. This patch saved about 1kB in ecryptfs
>> module.
>>
>> Signed-off-by: Jerome Marchand <jmarchan@xxxxxxxxxx>
>> ---
> 
> Thanks Jerome - We could also get away with marking
> ecryptfs_init_kmem_caches() and do_sysfs_registration() with __init,
> right?
> 
> Tyler
> 

I guess we could. But it doesn't really matter, these are static functions which
are called from only one place, so they're inlined anyway. I don't know what the
convention is in such case.

Jérôme
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/