Re: [git pull] vfs for rc2, part 1

From: Christoph Hellwig
Date: Wed Aug 18 2010 - 12:52:46 EST


On Wed, Aug 18, 2010 at 09:44:34AM -0700, Linus Torvalds wrote:
> On Wed, Aug 18, 2010 at 8:35 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Jan Kara (1):
> > ? ? ?vfs: update ctime when changing the file's permission by setfacl
>
> What dirties the inode for this case? It seems to just set i_ctime
> directly, how does it actually get written back to disk?
>
> Or is this purely a tmpfs/shmfs issue? Maybe a comment on that would
> have been good.

Yes, that code currently is just used for in-memory filesystems. Both
the generic_acl name for the file and the vfs: prefix for the patch
are rather confusing.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/