Re: lockdep false positive? -- firewire-core transaction timer vs.scsi-core host lock

[Clemens Ladisch]

Stefan Richter wrote:
> Clemens Ladisch wrote:
> >  	spin_lock_irqsave(&card->lock, flags);
> >  	list_for_each_entry(t, &card->transaction_list, link) {
> >  		if (t == transaction) {
> > +			if (!del_timer(&t->split_timeout_timer))
> > +				goto timed_out;
> 
> +			if (!del_timer(&t->split_timeout_timer)) {
> +				spin_unlock_irqrestore(&card->lock, flags);
> +				goto timed_out;
> +			}

> Shall I commit with the added spin_unlocks?

I can obviously not be trusted to do this correctly; please go ahead.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/