Re: lockdep false positive? -- firewire-core transaction timer vs.scsi-core host lock

[Stefan Richter]

Clemens Ladisch wrote:
> firewire: core: do not use del_timer_sync() in interrupt context
> 
> Because we might be in interrupt context, replace del_timer_sync() with
> del_timer().

Again, is the term "interrupt contexts" meant to include softIRQ contexts?

(Nothing in firewire-core/-sbp2/-net etc. is called in hardware
interrupts.  BTW, we actually could and maybe should change all the
spinlocks in them from spin_lock_irq to spin_lock_bh.  Only
firewire-ohci's local ohci->lock needs to be IRQ safe.  OTOH this could
change if somebody comes up with a migration of the stack to threaded
IRQ handling.)
-- 
Stefan Richter
-=====-==-=- =--- =--=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/