Re: [RFC PATCH 3/6] perf: Generalize some arch callchain code

[Frederic Weisbecker]

On Tue, Aug 17, 2010 at 01:46:34PM +1000, Paul Mackerras wrote:
> On Mon, Aug 16, 2010 at 10:48:32PM +0200, Frederic Weisbecker wrote:
> 
> > - Most archs use one callchain buffer per cpu, except x86 that needs
> >   to deal with NMIs. Provide a default perf_callchain_buffer()
> >   implementation that x86 overrides.
> > 
> > - Centralize all the kernel/user regs handling and invoke new arch
> >   handlers from there: perf_callchain_user() / perf_callchain_kernel()
> >   That avoid all the user_mode(), current->mm checks and so...
> > 
> > - Invert some parameters in perf_callchain_*() helpers: entry to the
> >   left, regs to the right, following the traditional (src, dst).
> 
> I think you mean (dst, src), don't you?


Indeed yeah :)



 
> Apart from that, the patch looks OK, so
> 
> Acked-by: Paul Mackerras <paulus@xxxxxxxxx>


Thanks a lot for your reviews and acks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/