Re: [PATCH] Input: fix faulty XXinput_* calls

[Daniel Mack]

On Sat, Aug 14, 2010 at 11:52:13PM +0200, Geert Uytterhoeven wrote:
> On Thu, Aug 12, 2010 at 18:22, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> > From: Daniel Mack <daniel@xxxxxxxx>
> >
> > They've been introduced by 987a6c02 ("Input: switch to input_abs_*()
> > access functions") and they appear to be some kind of debug left-over.
> >
> > [Dmitry Torokhov: these are my fault - I added XX prefixes in places where
> > ÂI wanted to do additional review of the code but failed to actually do
> > Âthat in these particular instances.]
> >
> > Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
> > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
> > ---
> >
> > Âdrivers/input/joystick/amijoy.c Â| Â Â2 +-
> 
> Thanks, amijoy.c compiles now.
> 
> But hil_kbd.c still doesn't compile:
> 
> > diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
> > index ddd5afd..dcc86b9 100644
> > --- a/drivers/input/keyboard/hil_kbd.c
> > +++ b/drivers/input/keyboard/hil_kbd.c
> > @@ -235,7 +235,7 @@ static void hil_dev_handle_ptr_events(struct hil_dev *ptr)
> > Â Â Â Â Â Â Â Â Â Â Â Âif (val < input_abs_min(dev, ABS_X + i))
> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âinput_abs_set_min(dev, ABS_X + i, val);
> > Â Â Â Â Â Â Â Â Â Â Â Âif (val > input_abs_max(dev, ABS_X + i))
> 
> error: implicit declaration of function âinput_abs_maxâ.
> 
> And indeed, input_abs_max() does not exist, while hil_kbd.c has 4 callers.

Sorry about that. hil_kbd wasn't built on my system with an
allmodconfig, as I just got to know. Below is a fix for this unfortunate
trouble.

Thanks,
Daniel