Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to2.6.35

From: Greg KH
Date: Tue Aug 17 2010 - 09:25:11 EST


On Tue, Aug 17, 2010 at 04:12:45PM +0900, Masayuki Ohtake wrote:
> > > > > On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote:
> > > > > > Hi Greg,
> > > > > >
> > > > > > > Do they all have to be ioctls? What exactly are they doing?
> > > > > > I think using ioctl is common for this patch.
> > > > >
> > > > > "Common" is not ok, right?
> > > > >
> > > > > > Do you think that using ioctl is NOT appropriate for this patch?
> > > > >
> > > > > Yes.
> > > > >
> > > > > > Let me know your intension in more detail.
> > > > >
> > > > > Please express yours. Why do you feel you need these to be ioctls?
> > > > > What exactly are they doing? Where is the documentation for them all?
> > >
> > > You forgot to answer this.
> > Ohtake-san,
> >
> > Please answer this question asap.
>
> Intel Topcliff IEEE1588 device driver API is developed according to Intel
> Tolapai 1588 device driver.
> Both APIs are the same.

That _still_ did not answer the questions. Please answer them.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/