Re: [PATCH 4/9] RapidIO: Add relation links between RIO device structures

From: Micha Nelissen
Date: Tue Aug 17 2010 - 03:08:44 EST


Bounine, Alexandre wrote:
As RapidIO is a switched network, the concept of 'previous' and 'next'
devices is invalid. Perhaps it's just the way they were
discovered/enumerated, but that does not matter any more at runtime.
Or at least, should not matter.


Yes, the "previous" and "next" have to be considered in context of
enumeration/discovery.
At runtime, it does not matter for data traffic, but is valuable
information for error recovery

I agree it's desirable to have this information. Notes:
1) is rio_dev->prev used anywhere? (maybe I missed it)
2) is the nextdev[port] list complete? I mean are all connected switches in the list? My guess is that multiply connected switches are enumerated only once therefore only appear in the nextdev if only one switch, instead of all
3) it would be nice to have all switch connections information.

In case ever the network is rerouted, this information will become useful; instead of having a tree representation of the network only.

Micha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/