Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset forsamsung2GbX8

From: David Woodhouse
Date: Mon Aug 16 2010 - 09:05:36 EST


On Mon, 2010-08-16 at 20:55 +0800, Eric Miao wrote:
> On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@xxxxxxxxxxx> wrote:
> > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html
> >
> > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches.
> >
> > By the way, David, what's the result of review on these patches? We already posted for several times.
> >
>
> I've actually reviewed some of the patches and gave my Ack. For those
> patches, I think they can be merged early.
>
> And overall, they look good. Yet 29 patch in a whole is still a bit too
> much, would be good to see them logically be separated into several
> patch series.

You had some criticism of patch #1 in the sequence, and some questions.

I didn't look much harder than that, iirc... although looking back now
it seems that the rest of your responses to the sequence were largely
positive.

Are you happy with the first patch, and if so shall I go ahead and
import the whole sequence with your Acked-By:?

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@xxxxxxxxx Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/