RE: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset forsamsung2GbX8

[Lei Wen]

Hi Axel,

I suggest not merge your patch into mainline code. Since I have a large series of patch which reconstruct the nand flash definition, this fix would no longer be needed.

Thanks,
Lei

-----Original Message-----
From: Eric Miao [mailto:eric.y.miao@xxxxxxxxx] 
Sent: 2010å8æ16æ 20:22
To: Axel Lin
Cc: linux-kernel; David Woodhouse; linux-mtd@xxxxxxxxxxxxxxxxxxx; Lei Wen; Haojian Zhuang
Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8

Cc'ed Lei and Haojian.

On Mon, Aug 16, 2010 at 4:50 PM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> This patch adds timing settings for samsung2GbX8 and
> fixes the cmdset settings. samsung2GbX8 is large page.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> Âdrivers/mtd/nand/pxa3xx_nand.c | Â 16 ++++++++++++++--
> Â1 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> index 4d89f37..47c0442 100644
> --- a/drivers/mtd/nand/pxa3xx_nand.c
> +++ b/drivers/mtd/nand/pxa3xx_nand.c
> @@ -227,9 +227,21 @@ static struct pxa3xx_nand_flash samsung512MbX16 = {
>    Â.chip_id    Â= 0x46ec,
> Â};
>
> +static struct pxa3xx_nand_timing samsung2GbX8_timing = {
> + Â Â Â .tCH Â Â= 5,
> + Â Â Â .tCS Â Â= 20,
> + Â Â Â .tWH Â Â= 10,
> + Â Â Â .tWP Â Â= 12,
> + Â Â Â .tRH Â Â= 10,
> + Â Â Â .tRP Â Â= 12,
> + Â Â Â .tR Â Â = 25000,
> + Â Â Â .tWHR Â = 60,
> + Â Â Â .tAR Â Â= 10,
> +};
> +
> Âstatic struct pxa3xx_nand_flash samsung2GbX8 = {
> -    .timing     = &samsung512MbX16_timing,
> -    .cmdset     = &smallpage_cmdset,
> +    .timing     = &samsung2GbX8_timing,
> +    .cmdset     = &largepage_cmdset,
> Â Â Â Â.page_per_block = 64,
>    Â.page_size   Â= 2048,
>    Â.flash_width  Â= 8,
> --
> 1.7.2
>
>
>
>
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_