Re: [PATCH] mmc: build fix: mmc_pm_notify is only available withCONFIG_PM=y

From: Maxim Levitsky
Date: Mon Aug 16 2010 - 03:51:24 EST


On Fri, 2010-08-13 at 13:01 +0300, Maxim Levitsky wrote:
> On Fri, 2010-08-13 at 11:24 +0200, Uwe Kleine-KÃnig wrote:
> > This fixes a build breakage introduced by
> >
> > 4c2ef25 (mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume)
> >
> > Cc: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> > Cc: David Brownell <david-b@xxxxxxxxxxx>
> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Cc: linux-mmc@xxxxxxxxxxxxxxx
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> > drivers/mmc/core/host.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > index 0efe631..d80cfdc 100644
> > --- a/drivers/mmc/core/host.c
> > +++ b/drivers/mmc/core/host.c
> > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
> > init_waitqueue_head(&host->wq);
> > INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> > INIT_DELAYED_WORK_DEFERRABLE(&host->disable, mmc_host_deeper_disable);
> > +#ifdef CONFIG_PM
> > host->pm_notify.notifier_call = mmc_pm_notify;
> > +#endif
> >
> > /*
> > * By default, hosts do not support SGIO or large requests.
>
> Hi,
>
> Sorry about that!


Hi folks,

Sorry again for this bug.
>From now on I will test compilation rigorously.

If you need it,
Acked-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx>

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/