Re: [PATCH 2/7] usb: fsl_udc_core: check return value ofcreate_proc_read_entry()

From: Dan Carpenter
Date: Sat Jul 31 2010 - 15:18:44 EST


On Sat, Jul 31, 2010 at 09:38:20PM +0400, Kulikov Vasiliy wrote:
> create_proc_read_entry() may fail, if so return -ENOMEM.
>

It can fail, but also we return NULL if procfs is disabled. I haven't
looked at it very carefully, would this patch break the module if procfs
was disabled?

The same applies to the similar patches in this set.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/