Re: [PATCH] tcp: cookie transactions setsockopt memory leak

From: David Miller
Date: Sat Jul 31 2010 - 02:05:40 EST


From: Dmitry Popov <dp@xxxxxxxxxxxxxxx>
Date: Thu, 29 Jul 2010 15:59:36 +0400

> From: Dmitry Popov <dp@xxxxxxxxxxxxxxx>
>
> There is a bug in do_tcp_setsockopt(net/ipv4/tcp.c),
> TCP_COOKIE_TRANSACTIONS case.
> In some cases (when tp->cookie_values == NULL) new tcp_cookie_values
> structure can be allocated (at cvp), but not bound to
> tp->cookie_values. So a memory leak occurs.
>
> Signed-off-by: Dmitry Popov <dp@xxxxxxxxxxxxxxx>

Applied and queued up for -stable, thanks Dmitry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/