Re: [PATCHv5 2/3] USB: gadget: Use new composite features in somegadgets

From: Greg KH
Date: Fri Jul 30 2010 - 12:55:52 EST


On Fri, Jul 30, 2010 at 06:48:41PM +0200, MichaÅ Nazarewicz wrote:
> >>-static unsigned short gfs_vendor_id = 0x0525; /* XXX NetChip */
> >>-static unsigned short gfs_product_id = 0xa4ac; /* XXX */
>
> >Look -- you can't assign NetChip numbers!!!
>
> /me ashamed
>
> Obviously, you're absolutely right. I left the XXX mark to remember
> to clear the situation with the IDs but then completely forgot about
> it after g_multi got pulled. (It's especially bad since there is a
> conflict with hid.c).
>
> So, to fix the situation, I need to ask Greg for the IDs?

Yes you do. We shouldn't be using _any_ netchip ids anymore now that we
have our own vendor id assigned to us.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/