Re: [PATCH] loop: add some basic read-only sysfs attributes

[Kay Sievers]

On Fri, Jul 30, 2010 at 09:43, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
> On Fri, Jul 30, 2010 at 09:37, Karel Zak <kzak@xxxxxxxxxx> wrote:
>> On Thu, Jul 29, 2010 at 06:07:31PM +0200, Kay Sievers wrote:
>>> Sure it does. Sysfs attributes need to be created _before_ uevents are
>>> sent out. The current behavior is that all blockdev attributes are
>>> safely created before the event is sent.
>>
>> ÂHmm... I see that in add_disk(), the "queue" subdirectory is created
>> Âafter disk registration (the register_disk() calls kobject_uevent()).
>> ÂIs it true?
>
> Might be. Then seems nobody has tried using this stuff from udev. :)
>
> blk_register_queue() probably needs to move to register_disk(), where
> the uevent is delayed until all stuff is properly created.

Seems, someone should finally move register_disk() from
fs/partition/check.c to block/genhd.c, where it belongs, and merge the
code into add_disk(), where the control over the event timing is
easily possible.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/