On Wed, Jul 28, 2010 at 07:14:42PM -0500, Jason Wessel wrote:On 07/28/2010 04:26 PM, Linus Torvalds wrote:On Wed, Jul 28, 2010 at 2:17 PM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:This should not be needed as the irqs should already be off while in the overflow handler.I'm sorry I spot it a bit late.Yeah, that's obviously crap. I also wonder why __kgdb_notify messes up
There is a little issue in this patch, irqs won't
be restored:
@@ -588,9 +588,10 @@ int kgdb_ll_trap(int cmd, const char *str,
if (!kgdb_io_module_registered)
return NOTIFY_DONE;
+ local_irq_save(flags);
return __kgdb_notify(&args, cmd);
+ local_irq_restore(flags);
}
the flags to begin with.
Interrupts are not disabled in the debug exception handler.
I'm not sure what would be the state of dr6 if a nested debug exception
would happen while do_debug() is interrupted.
Perhaps the previous dr6 value is dropped. Intel manuals don't seem to say anything
about that.
Anyway that's a separate issue. The current patch fixes a regression and
it looks good.
Thanks.
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport