Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul

[Andy Shevchenko]

On Wed, Jul 28, 2010 at 5:40 PM, Ernesto Ramos <ernesto@xxxxxx> wrote:
> Replace simple_strtoul by strict_strtoul in atoi function.
In general the question what is the purpose here to do the change?

> @@ -1023,7 +1025,9 @@ static s32 atoi(char *psz_buf)
> Â Â Â Â Â Â Â Âbase = 16;
> Â Â Â Â}
>
> - Â Â Â return simple_strtoul(pch, NULL, base);
> + Â Â Â ret_val = strict_strtoul(pch, base, &res);
> +
> + Â Â Â return ret_val ? : res;
May be better to use explicit values in condition?

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/