Re: [PATCH] random: reorder struct entropy_store to remove paddingon 64bits

From: Matt Mackall
Date: Wed Jul 28 2010 - 12:02:36 EST


On Wed, 2010-07-28 at 10:32 +0100, Richard Kennedy wrote:
> Re-order structure entropy_store to remove 8 bytes of padding on
> 64 bit builds, so shrinking this structure from 72 to 64 bytes
> and allowing it to fit into one cache line.

I have a vague memory that we reordered things so that the r/w bits
would be on a separate cache line than the r/o bits. But as we never
added the alignment primitives to actually enforce that, I guess it
doesn't matter much.

> Signed-off-by: Richard Kennedy <richard@xxxxxxxxxxxxxxx>

Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>

--
Mathematics is the supreme nostalgia of our time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/