[PATCH] firewire: ohci: release channel in error path

From: Stefan Richter
Date: Wed Jul 28 2010 - 09:50:22 EST

firewire-ohci keeps book of which isochronous channels are occupied by
IR DMA contexts, so that there cannot be more than one context listening
to a certain channel.

If IR context creation failed due to an out-of-memory condition, this
bookkeeping leaked a channel.

Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
drivers/firewire/ohci.c | 1 +
1 file changed, 1 insertion(+)

Index: b/drivers/firewire/ohci.c
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -2314,6 +2314,7 @@ static struct fw_iso_context *ohci_alloc
free_page((unsigned long)ctx->header);
spin_lock_irqsave(&ohci->lock, flags);
+ *channels |= 1ULL << channel;
*mask |= 1 << index;
spin_unlock_irqrestore(&ohci->lock, flags);

Stefan Richter
-=====-==-=- -=== ===--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/