Re: [PATCH 2/2] KVM: SVM: Emulate next_rip svm feature

From: Roedel, Joerg
Date: Wed Jul 28 2010 - 08:16:01 EST

On Wed, Jul 28, 2010 at 07:57:36AM -0400, Avi Kivity wrote:

> If the instruction opcode is on mmio, the processor never sees the
> opcode and thus can not intercept. Or the processor may see one
> instruction, which is not intercepted, but by the time the emulator
> kicks in a different instruction takes its place, since another vcpu is
> evilly cross-modifying the code.

Right. X-modifying code is a problem too.

> The guest (L2 in this case) is doomed since it execution cannot
> continue. But L1 and L0 are fine. The problem with L2 avoiding
> intercepts is that L2 can change control registers and take over L1.

Right too. We can not ignore it. The right fix is probably a check for
the instruction intercepts right after the decoder has run and before
the emulator ran.


Joerg Roedel - AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at