Re: [PATCH] DMAENGINE: generic slave channel control v3

From: Dan Williams
Date: Wed Jul 28 2010 - 03:28:12 EST


On Fri, Jul 23, 2010 at 10:27 AM, Linus Walleij
<linus.walleij@xxxxxxxxxxxxxx> wrote:
> This adds an interface to the DMAengine to make it possible to
> reconfigure a slave channel at runtime. We add a few foreseen
> config parameters to the passed struct, with a void * pointer
> for custom per-device or per-platform runtime slave data.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>

Ok, let's go with this version, but one question before I apply it:

What are the rules for when a new dma_slave_config can be set?
Looking at the driver implementations it seems there is nothing
preventing a concurrent call to device_control to occur at "wrong
time"? Is there a synchronization context I'm missing?

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/