Re: [PATCH] aic7xxx: Remove OS utility wrappers

From: Pekka Enberg
Date: Tue Jul 27 2010 - 13:56:01 EST

James Bottomley wrote:
On Mon, 2010-07-19 at 08:42 +0200, Hannes Reinecke wrote:
Pekka Enberg wrote:
This patch removes malloc(), free(), and printf() wrappers from the aic7xxx
SCSI driver. I didn't use pr_debug for printf because of some 'clever' uses of
printf don't compile with the pr_debug. I didn't fix the overeager uses of
GFP_ATOMIC either because I wanted to keep this patch as simple as possible.

Cc: Hannes Reinecke <hare@xxxxxxx>
Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxx>
Cc: Jiri Kosina <jkosina@xxxxxxx>
Cc: "Uwe Kleine-KÃnig" <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: "Andrà Goddard Rosa" <andre.goddard@xxxxxxxxx>
Cc: <linux-scsi@xxxxxxxxxxxxxxx>
Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
Thanks for the work. Long overdue.

Acked-by: Hannes Reinecke <hare@xxxxxxx>

A good rule of thumb is compile before acking:

drivers/scsi/aic7xxx/aic7770.c: In function 'aic7770_config':
drivers/scsi/aic7xxx/aic7770.c:224: error: implicit declaration of function 'free'
drivers/scsi/aic7xxx/aic7770.c:224: error: 'M_DEVBUF' undeclared (first use in this function)
drivers/scsi/aic7xxx/aic7770.c:224: error: (Each undeclared identifier is reported only once
drivers/scsi/aic7xxx/aic7770.c:224: error: for each function it appears in.)
make[3]: *** [drivers/scsi/aic7xxx/aic7770.o] Error 1

It looks like a lone missed conversion, so I fixed it up.

Sorry about that, I thought I tested all the configurations. Thanks for fixing it up!

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at