Re: [PATCH] ipmi: Fix ACPI detecting with regspacing

From: Yinghai Lu
Date: Tue Jul 27 2010 - 13:29:45 EST


On 07/27/2010 10:23 AM, Bjorn Helgaas wrote:
> On Tuesday, July 27, 2010 11:07:55 am Yinghai Lu wrote:
>> On 07/27/2010 08:34 AM, Bjorn Helgaas wrote:
>>> On Monday, July 26, 2010 03:48:02 pm Yinghai Lu wrote:
>>>>
>>>> after the commint that change ipmi_si detecting sequence from SMBIOS/ACPI to ACPI/SMBIOS,
>>>>
>>>> | commit 754d453185275951d39792865927ec494fa1ebd8
>>>> | Author: Matthew Garrett <mjg@xxxxxxxxxx>
>>>> | Date: Wed May 26 14:43:47 2010 -0700
>>>> |
>>>> | ipmi: change device discovery order
>>>> |
>>>> | The ipmi spec provides an ordering for si discovery. Change the driver to
>>>> | match, with the exception of preferring smbios to SPMI as HPs (at least)
>>>> | contain accurate information in the former but not the latter.
>>>>
>>>> ipmi_si can not be initialized.
>>>
>>> I think this patch makes sense, as long as this is not a bringup
>>> issue that only affects pre-release firmware. If this only affects
>>> a prototype, it would be better to change the firmware so it conforms
>>> to the conventional _CRS usage of systems in the field.
>>>
>>> To that end, I'd like to know what system this is, and whether IPMI
>>> works under Windows on this system. We know that Windows doesn't
>>> look at SMBIOS or SPMI, so if Windows works, it must be doing something
>>> similar to your patch.
>>
>> Sun Fire X4800.
>>
>> Yes. other OSes work and pass certification.
>
> Please put this information in the changelog (if that wasn't obvious).
>

I don't want to mention other os.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/