Re: [tip:x86/irq] x86: Always use irq stacks

[Christoph Hellwig]

Ingo, can you test this patch implementing Steve's suggestion?
Unfortunately I'm not able to reproduce the bug on my setup anymore.

---

From: Christoph Hellwig <hch@xxxxxx>
Subject: [PATCH] x86-32: align irq stacks properly

As suggested by Steven Rostedt we need to align the irq stacks on the
stack size, not just the page size to make them work for stack traces
with 8k stacks.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: linux-2.6-tip/arch/x86/kernel/irq_32.c
===================================================================
--- linux-2.6-tip.orig/arch/x86/kernel/irq_32.c	2010-07-27 14:06:50.634494682 +0200
+++ linux-2.6-tip/arch/x86/kernel/irq_32.c	2010-07-27 14:06:58.031494680 +0200
@@ -55,7 +55,7 @@ static inline void print_stack_overflow(
 union irq_ctx {
 	struct thread_info      tinfo;
 	u32                     stack[THREAD_SIZE/sizeof(u32)];
-} __attribute__((aligned(PAGE_SIZE)));
+} __attribute__((aligned(THREAD_SIZE)));
 
 static DEFINE_PER_CPU(union irq_ctx *, hardirq_ctx);
 static DEFINE_PER_CPU(union irq_ctx *, softirq_ctx);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/