Re: [PATCH] lib/scatterlist: Hook sg_kmalloc into kmemleak

From: Catalin Marinas
Date: Mon Jul 26 2010 - 16:56:10 EST


On Sun, 2010-07-25 at 15:21 +0100, Chris Wilson wrote:
> kmemleak ignores page_alloc() and so believes the final sub-page
> allocation using the plain kmalloc is decoupled and lost. This leads to
> lots of false-positives with code that uses scatterlists.
>
> The options seem to be either to tell kmemleak that the kmalloc is not
> leaked or to notify kmemleak of the page allocations. The danger of the
> first approach is that we may hide a real leak, so choose the latter
> approach (of which I am not sure of the downsides).

The patch looks fine to me. It would be useful to have some comment
where kmemleak_*() functions are called so that people reading the code
know why they are needed.

Thanks.

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/