Re: [git pull] drm-intel fixes since 2.6.35-rc4

[Jesse Barnes]

On Mon, 26 Jul 2010 13:19:14 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, Jul 26, 2010 at 12:13 PM, Eric Anholt <eric@xxxxxxxxxx> wrote:
> > The following changes since commit 815c4163b6c8ebf8152f42b0a5fd015cfdcedc78:
> >
> > ÂLinux 2.6.35-rc4 (2010-07-04 20:22:50 -0700)
> >
> > are available in the git repository at:
> > Âgit://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel for-linus
> 
> Hmm. This seems to introduce a new warning:
> 
>   drivers/gpu/drm/i915/intel_dp.c:744: warning:
> âironlake_edp_panel_offâ defined but not used
> 
> when I pulled it.
> 
> And the warning appears to be due to a real bug: instead of calling
> ironlake_edp_panel_off(), the code calls ironlake_edp_backlight_off()
> twice. I assume that the _intention_ was to call both the backlight
> and panel "off" routines, rather than making doubly sure that just the
> backlight is off by turning it off twice.
> 
> Tssk, tssk. Sadly, I noticed this too late, so now it's pulled and pushed out.

Arg.  Well at least the patch has been tested and is confirmed
working.  Fix for the warning on its way now (just going to test it to
make extra sure it still works when the panel actually gets shut off!)

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/