Re: [PATCH UPDATED 1/3] vhost: replace vhost_workqueue with per-vhostkthread

From: Tejun Heo
Date: Mon Jul 26 2010 - 12:07:01 EST


On 07/26/2010 05:50 PM, Michael S. Tsirkin wrote:
>> Hmmm... I'm not quite sure whether it's an optimization. I thought
>> the patch was due to feeling uncomfortable about using barriers?
> Oh yes. But getting rid of barriers is what motivated me originally.

Yeah, getting rid of barriers is always good. :-)

> Is there a git tree with kthread_worker applied?
> I might do this just for fun ...

git:// for-next

For the original implementaiton, please take a look at commit

* Can you please keep the outer goto repeat loop? I just don't like
outermost for (;;).

* Placing try_to_freeze() could be a bit annoying. It shouldn't be
executed when there's a work to flush.

* I think A - B <= 0 test would be more familiar. At least
time_before/after() are implemented that way.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at