Re: [PATCH] of: Provide default of_node_to_nid() when CONFIG_NUMAis not set

From: Stephen Rothwell
Date: Sat Jul 24 2010 - 23:07:51 EST

Hi Grant,

On Sat, 24 Jul 2010 09:43:31 -0600 Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> of_node_to_nid() is only relevant for NUMA. Don't force architectures to
> implement it if CONFIG_NUMA is not set.

Why not just do:

#ifndef of_node_to_nid
static inline int of_node_to_nid(struct device_node *device) { return 0; }
#define of_node_to_nid of_node_to_nid

in include/linux/of.h

and then add:

#define of_node_to_nid of_node_to_nid

Where it is declared/defined for each arch ...
(it would be nice if all the archs were consistent in where it was
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature