Re: [PATCHv4 13/14] writeback: remove unnecessary init_timer call

From: Christoph Hellwig
Date: Fri Jul 23 2010 - 12:28:20 EST


On Fri, Jul 23, 2010 at 06:05:53PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
>
> The 'setup_timer()' function also calls 'init_timer()', so the extra
> 'init_timer()' call is not needed. Indeed, 'setup_timer()' is basically
> 'init_timer()' plus callback function and data pointers initialization.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/