Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

[Jan Safranek]

On 07/23/2010 04:07 AM, Vivek Goyal wrote:
> On Thu, Jul 22, 2010 at 04:14:01PM -0700, Greg KH wrote:
> > On Fri, Jul 23, 2010 at 01:08:12AM +0200, Kay Sievers wrote:
> > > On Thu, Jul 22, 2010 at 23:18, Greg KH<gregkh@xxxxxxx>  wrote:
> > > > > For my testing I now always use /cgroup/ and create directories under it
> > > > > /cgroup/blkio /cgroup/cpu etc and mount controllers on respective
> > > > > directories.
> > > >
> > > > Lennart and Kay, is this what systemd is doing?  I really don't think we
> > > > should be adding a root /cgroup/ mount point to the system for something
> > > > like this.
> > >
> > > Already solved. Systemd always mounts an empty tmpfs at the 'cgroup'
> > > mountpoint, and stuff is free to create subdirs there. Systemd itself
> > > mount 'systemd' there.
> >
> > Ah, that makes it easier.  Paul and Vivek, any objection to this patch
> > going in now?
>
> This sounds reasonable to me also.
>
> Jan, I know you have been working in this area and raised concenrs about
> cgroup mount point in the past. Does it look good to you?

I would prefer some place where subdirectories can be created for 
individual hierarchies without additional tmpfs there. But as I 
understand /sys, it's not an easy feature to implement it there, so no, 
I am not against /sys/fs/cgroup.

Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/