Re: [PATCH] Re: perf annotate segfaults when source code has gotolabel that looks like hex number

[Arnaldo Carvalho de Melo]

Em Thu, Jul 22, 2010 at 01:47:11PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jul 22, 2010 at 07:38:51PM +0300, Gleb Natapov escreveu:
> > On Thu, Jul 22, 2010 at 11:33:45AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Can you try the attached patch?
> > > 
> > I can, only later. But if I underhand your patch correctly perf will
> > still crash if there is a comment after the label on the same line.
> 
> Possibly, will try that now.

It could be a comment of play code, like:

[root@emilia ~]# cat test.c 
int main(int argc, char **argv)
{
      int i;

      while(1) {
              i++;
              if (i == 10000000)
                      goto add;
      }
add:	return 0;
}
[root@emilia ~]#

back to the drawing board :-\

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/