Re: [PATCH] USB: core: Choose configuration with lowestbConfigurationValue

From: MichaÅ Nazarewicz
Date: Thu Jul 22 2010 - 10:26:46 EST


On Thu, 22 Jul 2010, Michal Nazarewicz wrote:
This patch removes code from usb_choose_configuration()
responsible for ignoring the first USB device configuration if
its first interface is RNDIS. Instead,
usb_choose_configuration() chooses configuration with lowest
bConfigurationValue. Linux' Ethernet gadget uses a lower
bConfigurationValue for the second configuration which is
a CDC configuration so this code should choose configuration
that suits Linux better.

On Thu, 22 Jul 2010 16:22:37 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
I don't like this idea. Choosing configs is a sensitive topic, since
it is highly visible to users. It should be changed minimally, if at
all.

Fine by me. I've just posted it to show what I had in mind.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, MichaÅ "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/