Re: [PATCHv2 11/11] writeback: prevent unnecessary bdi threadswakeups

[Christoph Hellwig]

On Thu, Jul 22, 2010 at 10:41:55AM +1000, Dave Chinner wrote:
> 	if (wakeup_bdi) {
> 		trace_writeback_wakeup(bdi)
> 		spin_lock(&bdi->wb_lock);
> 		if (!bdi->wb.task) {{
> 			trace_writeback_wakeup_nothread(bdi);
> 			wake_up_process(default_backing_dev_info.wb.task);
> 		} else
> 			wake_up_process(bdi->wb.task);
> 		spin_unlock(&bdi->wb_lock);

That gives us duplicate traces for the first case, what about:

	 if (wakeup_bdi) {
	 	spin_lock(&bdi->wb_lock);
		if (bdi->wb.task) {
			trace_writeback_wake_thread(bdi);
			wake_up_process(bdi->wb.task);
		} else {
			trace_writeback_wake_forker_thread(bdi);
			wake_up_process(default_backing_dev_info.wb.task);
		}
		spin_unlock(&bdi->wb_lock);
	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/