Re: [PATCHv2 04/11] writeback: do not lose wake-ups in the forkerthread - 2

[Christoph Hellwig]

On Wed, Jul 21, 2010 at 12:31:39PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
> 
> Currently, if someone submits jobs for the default bdi, we can lose wake-up
> events. E.g., this can happen if 'bdi_queue_work()' is called when
> 'bdi_forker_thread()' is executing code after 'wb_do_writeback(me, 0)', but
> before 'set_current_state(TASK_INTERRUPTIBLE)'.
> 
> This situation is unlikely, and the result is not very severe - we'll just
> delay the execution of the work, but this is still not very nice.
> 
> This patch fixes the issue by checking whether the default bdi has works before
> the forker thread goes sleep.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/