Re: [PATCH 1/8] arm/mach-tegra: fix unsigned calcs

[Mike Rapoport]

Colin Cross wrote:
> On Thu, Jul 15, 2010 at 11:43 AM, Kulikov Vasiliy <segooon@xxxxxxxxx> wrote:
> > divider_u71 is unsigned, so this check is buggy:
> > if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)
> >
> > If divider_u71 is 0 or 1 both checks are lying.
> > So, it does not produce a buggy answer, but it is confusing.
>
> Hi Kulikov,

The first name is Vasiliy :)

> Thanks for the patch.  This problem has been fixed in another patch in
> the linux-tegra tree, I'll post it for review and update the
> linux-next tree soon.
>
> Colin Cross
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/