Re: [PATCH 10/15] fs: cifs: check kmalloc() result

From: Steve French
Date: Mon Jul 19 2010 - 17:58:39 EST


merged into cifs-2.6.git

On Fri, Jul 16, 2010 at 11:15 AM, Kulikov Vasiliy <segooon@xxxxxxxxx> wrote:
> If kmalloc() fails exit with -ENOMEM.
>
> Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>
> ---
>  fs/cifs/readdir.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
> index daf1753..d5e591f 100644
> --- a/fs/cifs/readdir.c
> +++ b/fs/cifs/readdir.c
> @@ -847,6 +847,11 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir)
>                end_of_smb = cifsFile->srch_inf.ntwrk_buf_start + max_len;
>
>                tmp_buf = kmalloc(UNICODE_NAME_MAX, GFP_KERNEL);
> +               if (tmp_buf == NULL) {
> +                       rc = -ENOMEM;
> +                       break;
> +               }
> +
>                for (i = 0; (i < num_to_fill) && (rc == 0); i++) {
>                        if (current_entry == NULL) {
>                                /* evaluate whether this case is an error */
> --
> 1.7.0.4
>
>



--
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/