Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

[David Brownell]

--- On Mon, 7/19/10, MichaÅ Nazarewicz <m.nazarewicz@xxxxxxxxxxx> wrote:

> I'm not entirely sure of what the issue with
> the patches is really. It merely adds a serial
> number to the gadgets using MSF and that's all.

Go back and read what I wrote then.  The issue is
that THERE ALREADY IS SUCH A MECHANISM.  We neither
need or want another way to do it.  The answer is to
use the existing mechanism correctly.

Plus, you seem to be overlooking the basic need
(for userspace) to manage these IDs so they're
properly unique.  Two gadgets should never end up
using the same serial number.

I tire of repeating these basic points...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/