Re: [PATCH 11/15] pci: echoaudio: check kmalloc() result

[Takashi Iwai]

At Fri, 16 Jul 2010 21:16:50 +0200,
Giuliano Pochini wrote:
> 
> On Fri, 16 Jul 2010 20:15:43 +0400
> Kulikov Vasiliy <segooon@xxxxxxxxx> wrote:
> 
> > If kmalloc() fails exit with -ENOMEM.
> > 
> > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>
> > ---
> >  sound/pci/echoaudio/echoaudio.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
> > index 668a5ec..20763dd 100644
> > --- a/sound/pci/echoaudio/echoaudio.c
> > +++ b/sound/pci/echoaudio/echoaudio.c
> > @@ -2250,6 +2250,8 @@ static int snd_echo_resume(struct pci_dev *pci)
> >  	DE_INIT(("resume start\n"));
> >  	pci_restore_state(pci);
> >  	commpage_bak = kmalloc(sizeof(struct echoaudio), GFP_KERNEL);
> > +	if (commpage_bak == NULL)
> > +		return -ENOMEM;
> >  	commpage = chip->comm_page;
> >  	memcpy(commpage_bak, commpage, sizeof(struct comm_page));
> >  
> 
> Yes, of course. Thank you.
> 
> 
> Ack-by: Giuliano Pochini <pochini@xxxxxxxx>

Applied now.  Thanks.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/