Re: [PATCH] x86: kprobes: fix swapped segment registers in kretprobe

[Linus Torvalds]

On Sun, Jul 18, 2010 at 3:11 PM, Roland McGrath <roland@xxxxxxxxxx> wrote:
>
> [PATCH] x86: kprobes: fix swapped segment registers in kretprobe
>
> In commit f007ea26, the order of the %es and %ds segment registers
> got accidentally swapped, so synthesized 'struct pt_regs' frames
> have the two values inverted.  It's almost sure that these values
> never matter, and that they also never differ.  But wrong is wrong.

Heh, yes. ES and DS are almost guaranteed to be the same, or string
instructions act oddly. But I could imagine that some wine usage could
trigger this. Of course, you'd also have to have probes etc.

Regardless - pulled,

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/