Fixed several issues that made the 8139C+ driver nonconformant to the Linux coding style guidelines.
Signed-off-by: Joseph Kogut<joseph.kogut@xxxxxxxxx>
---
drivers/net/8139cp.c | 304 +++++++++++++++++++++++++-------------------------
1 files changed, 153 insertions(+), 151 deletions(-)
/*
Copyright 2001-2004 Jeff Garzik<jgarzik@xxxxxxxxx>
- Copyright (C) 2001, 2002 David S. Miller (davem@xxxxxxxxxx) [tg3.c]
- Copyright (C) 2000, 2001 David S. Miller (davem@xxxxxxxxxx) [sungem.c]
- Copyright 2001 Manfred Spraul [natsemi.c]
- Copyright 1999-2001 by Donald Becker. [natsemi.c]
- Written 1997-2001 by Donald Becker. [8139too.c]
- Copyright 1998-2001 by Jes Sorensen,<jes@xxxxxxxxxxxxxxxxxx>. [acenic.c]
+ Copyright (C) 2001, 2002 David S. Miller (davem@xxxxxxxxxx) [tg3.c]
+ Copyright (C) 2000, 2001 David S. Miller (davem@xxxxxxxxxx) [sungem.c]
+ Copyright 2001 Manfred Spraul [natsemi.c]
+ Copyright 1999-2001 by Donald Becker. [natsemi.c]
+ Written 1997-2001 by Donald Becker. [8139too.c]
+ Copyright 1998-2001 by Jes Sorensen,<jes@xxxxxxxxxxxxxxxxxx>. [acenic.c]
@@ -1295,32 +1295,32 @@ static void mdio_write(struct net_device *dev, int phy_id, int location,
}
/* Set the ethtool Wake-on-LAN settings */
-static int netdev_set_wol (struct cp_private *cp,
+static int netdev_set_wol(struct cp_private *cp,
const struct ethtool_wolinfo *wol)
{
u8 options;
- options = cpr8 (Config3)& ~(LinkUp | MagicPacket);
+ options = cpr8(Config3)& ~(LinkUp | MagicPacket);
/* If WOL is being disabled, no need for complexity */
if (wol->wolopts) {
- if (wol->wolopts& WAKE_PHY) options |= LinkUp;
- if (wol->wolopts& WAKE_MAGIC) options |= MagicPacket;
+ if (wol->wolopts& WAKE_PHY) options |= LinkUp;
+ if (wol->wolopts& WAKE_MAGIC) options |= MagicPacket;
}
- cpw8 (Cfg9346, Cfg9346_Unlock);
- cpw8 (Config3, options);
- cpw8 (Cfg9346, Cfg9346_Lock);
+ cpw8(Cfg9346, Cfg9346_Unlock);
+ cpw8(Config3, options);
+ cpw8(Cfg9346, Cfg9346_Lock);
options = 0; /* Paranoia setting */
- options = cpr8 (Config5)& ~(UWF | MWF | BWF);
+ options = cpr8(Config5)& ~(UWF | MWF | BWF);
/* If WOL is being disabled, no need for complexity */
if (wol->wolopts) {
- if (wol->wolopts& WAKE_UCAST) options |= UWF;
- if (wol->wolopts& WAKE_BCAST) options |= BWF;
- if (wol->wolopts& WAKE_MCAST) options |= MWF;
+ if (wol->wolopts& WAKE_UCAST) options |= UWF;
+ if (wol->wolopts& WAKE_BCAST) options |= BWF;
+ if (wol->wolopts& WAKE_MCAST) options |= MWF;
}
@@ -1328,35 +1328,36 @@ static int netdev_set_wol (struct cp_private *cp,
}
/* Get the ethtool Wake-on-LAN settings */
-static void netdev_get_wol (struct cp_private *cp,
- struct ethtool_wolinfo *wol)
+static void netdev_get_wol(struct cp_private *cp,
+ struct ethtool_wolinfo *wol)
{
u8 options;
wol->wolopts = 0; /* Start from scratch */
- wol->supported = WAKE_PHY | WAKE_BCAST | WAKE_MAGIC |
- WAKE_MCAST | WAKE_UCAST;
+ wol->supported = WAKE_PHY | WAKE_BCAST | WAKE_MAGIC | WAKE_MCAST | WAKE_UCAST;
+
/* We don't need to go on if WOL is disabled */
- if (!cp->wol_enabled) return;
+ if (!cp->wol_enabled)
+ return;
- options = cpr8 (Config3);
- if (options & LinkUp) wol->wolopts |= WAKE_PHY;
- if (options & MagicPacket) wol->wolopts |= WAKE_MAGIC;
+ options = cpr8(Config3);
+ if (options & LinkUp) wol->wolopts |= WAKE_PHY;
+ if (options & MagicPacket) wol->wolopts |= WAKE_MAGIC;
options = 0; /* Paranoia setting */
- options = cpr8 (Config5);
- if (options & UWF) wol->wolopts |= WAKE_UCAST;
- if (options & BWF) wol->wolopts |= WAKE_BCAST;
- if (options & MWF) wol->wolopts |= WAKE_MCAST;
+ options = cpr8(Config5);
+ if (options & UWF) wol->wolopts |= WAKE_UCAST;
+ if (options & BWF) wol->wolopts |= WAKE_BCAST;
+ if (options & MWF) wol->wolopts |= WAKE_MCAST;
}
-static void cp_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo *info)