Re: [PATCH 1/2] x86: fix keeping track of AMD C1E

From: H. Peter Anvin
Date: Fri Jul 16 2010 - 12:03:23 EST


On 07/16/2010 12:22 AM, Borislav Petkov wrote:
>>
>> No, the difference between using a separate variable and the CPU feature
>> bit is that CPU feature bit is ANDed across all CPUs, whereas this
>> variable is set if it is set on *any* CPU.
>
> ... and that's ok because the MSR bits get set on all cores after BIOS
> turns on C1E. Let me verify this though.
>

Is there any reason for the OR behavior? Otherwise, it's just plain
wrong...

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/