Re: [PATCH] twl6040: fix wrong kfree in twl6040_remove and twl6040_codec_remove

From: Axel Lin
Date: Fri Jul 16 2010 - 05:54:34 EST


hi Mark,

2010/7/16 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:
> On Fri, Jul 16, 2010 at 05:26:48PM +0800, Axel Lin wrote:
>> Memory allocation part:
>> We allocate a memory in twl6040_codec_probe():
>>         priv = kzalloc(sizeof(struct twl6040_data), GFP_KERNEL);
>>         twl6040_codec = codec = &priv->codec;
>
> Could you please try to take on board the feedback you were given
> yesterday about this sort of stuff?  Both the feedback about formatting
> your patch so it's easy to apply and the collisions with other, more
> substantial, work that's going on?
>
Ok. I will resend the patch.
( I just thought it may takes some time for review )
( Due a vacation this weekend, I'll do it next Monday )

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/