Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," toterminate statements

[Thomas Gleixner]

On Wed, 14 Jul 2010, Joe Perches wrote:

Sorry, but that's one of the most convoluted changelogs I ever saw. 

> These are the only "," terminated statements that
> precede a pr_<level> in the kernel tree.

Errm, why is this related to pr_<level> in any way ?
 
> These must be ";" terminated if the pr_<level>
> macros becomes a bit more space efficient using
> a "do { foo } while (0)" form.

It has absolutely _NOTHING_ to do with any implementation detail of
the function/macro which comes after those statements.

Terminating a statement with a comma is simply wrong by itself and it
needs to be fixed w/o further ado.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/