Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [3/5] Initializelink state at probe time

From: David Miller
Date: Wed Jul 14 2010 - 17:10:45 EST


From: Shreyas Bhatewara <sbhatewara@xxxxxxxxxx>
Date: Tue, 13 Jul 2010 17:48:55 -0700 (PDT)

>
> Initialize vmxnet3 link state at probe time
>
> This change initializes the state of link at the time when driver is
> loaded. The ethtool output for 'link detected' and 'link speed'
> is thus valid even before the interface is brought up.
>
> Signed-off-by: Shreyas Bhatewara <sbhatewara@xxxxxxxxxx>

You should never, ever, call netif_start_queue() on a device which has
not been brought up.

But that is what this patch is doing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/