Re: [PATCH] wm8727: add a missing return in wm8727_platform_probe

From: Liam Girdwood
Date: Wed Jul 14 2010 - 11:07:46 EST


On Wed, 2010-07-14 at 18:57 +0800, Axel Lin wrote:
> otherwise the error path will always be executed.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> sound/soc/codecs/wm8727.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c
> index 1072621..9d1df26 100644
> --- a/sound/soc/codecs/wm8727.c
> +++ b/sound/soc/codecs/wm8727.c
> @@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
> goto err_codec;
> }
>
> + return 0;
> +
> err_codec:
> snd_soc_unregister_codec(codec);
> err:

Both

Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/