Re: Dynamic Debug broken on 2.6.35-rc3?

[Yehuda Sadeh]

On Mon, 2010-07-12 at 23:47 +0200, Andi Kleen wrote:
> On Mon, Jul 12, 2010 at 12:21:40PM -0400, Jason Baron wrote:
> > On Mon, Jul 12, 2010 at 04:24:16PM +0200, Thomas Renninger wrote:
> > > Hi,
> > > 
> > > it's this one:
> > > commit ff49d74ad383f54041378144ca1a229ee9aeaa59
> > > Author: Yehuda Sadeh <yehuda@xxxxxxxxxxxxxxx>
> > > Date:   Sat Jul 3 13:07:35 2010 +1000
> > > 
> > > which touches same code than Jason's fix does.
> > > Possibly this patch also addresses (only parts of?) this problem?
> > > Jason: Do you mind having a look at the latest git version and review
> > > Yehuda's  and adjust your patch if still necessary.
> > 
> > So Yehuda's patch is meant to address this issue. I would still move the
> > remove code to free_module(), for the case that load_module() fails as
> > follows (on top of Yehuda's patch):
> 
> One of the known failures with this was a module that was just missing its exit
> function, but otherwise working. Is the patch likely to address this
> too? 
> 
I'm not sure about a known issue with a missing exit function. Looking
at the latest git, it doesn't seem there is a problem there. However,
there is an issue with the module init function returning an error.
Jason's fix on top of my patch solves it.

Yehuda

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/