Re: [PATCH v5 6/9] KVM: MMU: introduce pte_prefetch_topup_memory_cache()

[Avi Kivity]

On 07/13/2010 09:52 AM, Xiao Guangrong wrote:
> > > > What about the Linux accessed and dirty bits?  Need to instantiate the
> > > > speculative sptes with accessed and dirty bits clear (and later examine
> > > > them when we release the page).
> > > >
> > > >
> > > >          
> > > I see, will do :-)
> > >
> > >        
> > This is getting bigger and bigger...
> >
> >      
> What are you worry about? or has fault in this way? :-(
>    

I'm worried about such changes having unforeseen impact, but that's a 
fact of life, we have to live with it.

My other worry is about complexity growing.  Every once in a while we 
need to refactor things so the code remains readable (like I did with 
the fetch() rewrite).

So, keep going, and don't worry about me being worried :)

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/