Re: [PATCH] i2c: cyttsp i2c touchscreen driver init submit

From: Henrik Rydberg
Date: Tue Jul 13 2010 - 02:51:00 EST


Kevin McNeely wrote:
> From: Fred <fwk@xxxxxxxxxxxxxxxxxxxxxxxxx>
>
> This is a new touchscreen driver for the Cypress Semiconductor
> cyttsp family of devices. This driver is for the i2c version
> of cyttsp parts.
>
> Signed-off-by: Kevin McNeely <kev@xxxxxxxxxxx>
> ---

This driver contains too much code. I am wondering if the device actually
supports tracking id, or whether it is emulated in the driver code? If tracking
is not well supported in hardware, then please use MT protocol A and remove the
usage of ABS_MT_TRACKING_ID and the logic around it. If tracking is indeed well
supported in the hardware, then please use MT protocol B.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/