Re: [PATCH v5 6/9] KVM: MMU: introduce pte_prefetch_topup_memory_cache()

[Avi Kivity]

On 07/13/2010 08:48 AM, Xiao Guangrong wrote:
> > Right.  We should fix those too.
> >
> > Prefetch is much more worrying though, especially with ept.  If a guest
> > is using just 1/8 of the pages, it can look to migration as if it's
> > using 100% of the pages.  The impact can be pretty large.
> >      
> We disabled prefetch if ept is enabled since it can break access bit tracking.
>    

Oh yes.

> I'll fix the dirty bit tracking before post the new version of this patchset.
>    

Should be simple - disable prefetch for slots that have dirty tracking 
enabled.

What about the Linux accessed and dirty bits?  Need to instantiate the 
speculative sptes with accessed and dirty bits clear (and later examine 
them when we release the page).

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/